-
Notifications
You must be signed in to change notification settings - Fork 18.5k
net: parse addresses without separators in ParseMac #76387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: 8a2efb0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/722720. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Devon Mar: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 2: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-11-21T08:47:41Z","revision":"608569b00e7d587f5aa46cc01e08f0170e52493f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Devon Mar: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Devon Mar: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 4: Auto-Submit+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Damien Neil: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 4: -Auto-Submit -Code-Review Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
This PR (HEAD: 77900cc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/722720. Important tips:
|
|
Message from Devon Mar: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Damien Neil: Patch Set 5: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-12-02T08:47:15Z","revision":"3a11a369de800783cb407622bd94ff96c2b627fc"} Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Sean Liao: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/722720. |
IEEE EUI guidelines states that "an EUI-48 can be represented in the IEEE RA hexadecimal (hex) form with the octets separated by hyphens, or as a pure base-16 numerical representation without hyphens" (https://standards.ieee.org/wp-content/uploads/import/documents/tutorials/eui.pdf p.9). The latter form is used in Azure Instance Metadata Service (Azure/azure-container-networking#4122) among others. Fixes #66682 Change-Id: Id66c23d50ebb1fed1f3bdb5cf3822a8fd60b886d GitHub-Last-Rev: 77900cc GitHub-Pull-Request: #76387 Reviewed-on: https://go-review.googlesource.com/c/go/+/722720 Auto-Submit: Damien Neil <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
|
This PR is being closed because golang.org/cl/722720 has been merged. |
IEEE EUI guidelines states that "an EUI-48 can be represented in the IEEE RA
hexadecimal (hex) form with the octets separated by hyphens, or as a pure
base-16 numerical representation without hyphens"
(https://standards.ieee.org/wp-content/uploads/import/documents/tutorials/eui.pdf p.9).
The latter form is used in Azure Instance Metadata Service
(Azure/azure-container-networking#4122) among others.
Fixes #66682